Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades the SingleStore Entity Framework Core provider from version 8.0.2 to 8.0.3. It includes dependency updates, a critical bug fix for Math.Log translation, improvements to connection string handling, and updates to default character set configurations.
Changes:
- Updated EF Core dependencies from 8.0.2 to 8.0.13 and other package versions
- Fixed Math.Log SQL translation to correctly reverse arguments (C#
Math.Log(value, base)→ SQLLOG(base, value)) - Improved connection attribute handling to avoid unnecessary connection string mutations
- Changed default charset from utf8 to utf8mb4 and GUID collation from utf8_general_ci to utf8mb4_bin
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Version.props | Updated version from 8.0.2 to 8.0.3 |
| Dependencies.targets | Updated EF Core and related package versions from 8.0.2 to 8.0.13 |
| dotnet-tools.json | Updated dotnet-ef tool version |
| src/EFCore.SingleStore/Query/Internal/SingleStoreMathMethodTranslator.cs | Added ReverseArgs flag to fix Math.Log argument order bug |
| src/EFCore.SingleStore/Storage/Internal/SingleStoreConnectionStringOptionsValidator.cs | Refactored to only add connection attributes when flags are changed |
| src/EFCore.SingleStore/Storage/Internal/SingleStoreRelationalConnection.cs | Consolidated connection attribute handling logic |
| src/EFCore.SingleStore/Internal/SingleStoreOptions.cs | Changed defaults to utf8mb4 charset and utf8mb4_bin collation |
| test/EFCore.SingleStore.Tests/ValueGeneration/Internal/SingleStoreSequentialGuidValueGeneratorTest.cs | Fixed class name from MysqlSequentialGuidValueGeneratorTest |
| test/EFCore.SingleStore.FunctionalTests/SingleStoreConnectionStringOptionsValidatorTests.cs | Refactored tests with helper methods and updated assertions |
| test/EFCore.SingleStore.FunctionalTests/Query/*.cs | Added new test methods and updated SQL baselines |
| test/EFCore.SingleStore.FunctionalTests/MigrationsSingleStoreTest.cs | Updated expected SQL for charset changes and added primitive collection tests |
| test/EFCore.SingleStore.FunctionalTests/ConnectionSettingsSingleStoreTest.cs | Updated expected GUID formats to lowercase |
| test/EFCore.SingleStore.FunctionalTests/BadDataJsonDeserializationSingleStoreTest.cs | Fixed class name and skipped unsupported geospatial test |
| .github/workflows/test_setup/*.{sh,ps1} | Added additional test filters for new test classes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| var nameAttr = "_connector_name:SingleStore Entity Framework Core provider"; | ||
| var versionAttr = $"_connector_version:{programVersion}"; | ||
|
|
||
| var changed = existingAttrs.Add(nameAttr) | existingAttrs.Add(versionAttr); |
There was a problem hiding this comment.
Potentially dangerous use of non-short circuit logic.
| var nameAttr = "_connector_name:SingleStore Entity Framework Core provider"; | ||
| var versionAttr = $"_connector_version:{programVersion}"; | ||
|
|
||
| var changed = existingAttrs.Add(nameAttr) | existingAttrs.Add(versionAttr); |
There was a problem hiding this comment.
Potentially dangerous use of non-short circuit logic.
Suggested change
| var changed = existingAttrs.Add(nameAttr) | existingAttrs.Add(versionAttr); | |
| var addedNameAttr = existingAttrs.Add(nameAttr); | |
| var addedVersionAttr = existingAttrs.Add(versionAttr); | |
| var changed = addedNameAttr || addedVersionAttr; |
pmishchenko-ua
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.